Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid emitting events with empty data #91

Open
wants to merge 1 commit into
base: fix/internal-review
Choose a base branch
from
Open

fix: avoid emitting events with empty data #91

wants to merge 1 commit into from

Conversation

xorsal
Copy link
Contributor

@xorsal xorsal commented Dec 18, 2024 •
edited
Loading

🤖 Linear

Closes OPT-586

@linear Linear
Copy link

linear bot commented Dec 18, 2024

OPT-586 [L-3] When finalizing without a response, events are emitted without information

ashitakah
ashitakah approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@ashitakah ashitakah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which case the response will be empty? I would like to know in which flow is this possible. Even so, is only 1 line, to ensure the request Id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashitakah ashitakah ashitakah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xorsal @ashitakah