Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rework IOracleAccessController::setAccessModule #74

Open
wants to merge 2 commits into
base: fix/internal-review
Choose a base branch
from
Open

fix: rework IOracleAccessController::setAccessModule #74

wants to merge 2 commits into from

Conversation

xorsal
Copy link
Contributor

@xorsal xorsal commented Dec 18, 2024

🤖 Linear

Closes OPT-585

@xorsal
fix: split setAccessModule into two more verbose functions
1101c3d 
now we have `approveAccessModule(address)` and `revokeAccessModule(address)`,
one to approve an access module address,
and another one to revoke a previously approved access module.
@xorsal
test: update setAccessModule related tests
0b5dfef
@linear Linear
Copy link

linear bot commented Dec 18, 2024

OPT-585 [L-2] setAccessModule should be simpler and better named

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashitakah ashitakah ashitakah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xorsal @ashitakah