Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: m-05 modifier in virtual function #61

Open
wants to merge 1 commit into
base: fix/oz-audit
Choose a base branch
from
Open

fix: m-05 modifier in virtual function #61

wants to merge 1 commit into from

Conversation

0xShaito
Copy link
Member

@0xShaito 0xShaito commented Dec 10, 2024 •
edited
Loading

🤖 Linear

Closes OPT-567

@0xShaito 0xShaito changed the base branch from dev to fix/oz-audit December 10, 2024 15:28
@linear Linear
Copy link

linear bot commented Dec 10, 2024

OPT-567 M-05 Modifier In Virtual Function Does Not Persist When Overridden

ashitakah
ashitakah approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@ashitakah ashitakah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we any impact implementing this in EBO?

@xorsal
Copy link
Contributor

xorsal commented Dec 17, 2024

I haven't personally checked, but I assume it will conflict, and since we're also waiting for the other OZ audits, I expect the merge-cascade process to be long and cumbersome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xorsal xorsal xorsal approved these changes

@ashitakah ashitakah ashitakah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xShaito @xorsal @ashitakah