Skip to content

Commit

Permalink
test: remove fuzz in integration tests
Browse files Browse the repository at this point in the history
  • Loading branch information
xorsal committed Nov 21, 2024
1 parent 819e5fe commit 807cd6e
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
6 changes: 4 additions & 2 deletions solidity/test/integration/Finalization.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ contract Integration_Finalization is IntegrationBase {
/**
* @notice Test to check that finalization data is set and callback calls are made.
*/
function test_makeAndIgnoreLowLevelCalls(bytes memory _calldata) public {
function test_makeAndIgnoreLowLevelCalls() public {
bytes memory _calldata = bytes('calldata');
mockRequest.finalityModuleData =
abi.encode(IMockFinalityModule.RequestParameters({target: _callbackTarget, data: _calldata}));

Expand Down Expand Up @@ -115,7 +116,8 @@ contract Integration_Finalization is IntegrationBase {
/**
* @notice Test to check that finalizing a request without disputes triggers callback calls and executes without reverting.
*/
function test_finalizeWithUndisputedResponse(bytes calldata _calldata) public {
function test_finalizeWithUndisputedResponse() public {
bytes memory _calldata = bytes('some-calldata');
mockRequest.finalityModuleData =
abi.encode(IMockFinalityModule.RequestParameters({target: _callbackTarget, data: _calldata}));

Expand Down
8 changes: 5 additions & 3 deletions solidity/test/integration/ResponseProposal.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ contract Integration_ResponseProposal is IntegrationBase {
_requestId = oracle.createRequest(mockRequest, _ipfsHash, mockAccessControl);
}

function test_proposeResponse_validResponse(bytes memory _response) public {
function test_proposeResponse_validResponse() public {
bytes memory _response = bytes('valid-response');
mockResponse.response = _response;

// Revert if not approved to create request
Expand Down Expand Up @@ -79,8 +80,9 @@ contract Integration_ResponseProposal is IntegrationBase {
assertEq(_responseIds[0], _getId(mockResponse));
}

function test_proposeResponse_finalizedRequest(uint256 _timestamp) public {
_timestamp = bound(_timestamp, _expectedDeadline + _baseDisputeWindow, type(uint128).max);
function test_proposeResponse_finalizedRequest() public {
uint256 _timestamp = _expectedDeadline + _baseDisputeWindow;
// _timestamp = bound(_timestamp, _expectedDeadline + _baseDisputeWindow, type(uint128).max);

// Propose response
mockAccessControl.user = proposer;
Expand Down

0 comments on commit 807cd6e

Please sign in to comment.