Skip to content

Commit

Permalink
fix: change mapping variable names in favor of clarity
Browse files Browse the repository at this point in the history
  • Loading branch information
xorsal committed Dec 10, 2024
1 parent 3e1078a commit 6231e6a
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions solidity/contracts/Oracle.sol
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ contract Oracle is IOracle, OracleAccessController {
mapping(bytes32 _requestId => uint256 _finalizedAt) public finalizedAt;

/// @inheritdoc IOracle
mapping(bytes32 _id => uint256 _requestCreatedAt) public requestCreatedAt;
mapping(bytes32 _requestId => uint256 _requestCreatedAt) public requestCreatedAt;

/// @inheritdoc IOracle
mapping(bytes32 _id => uint256 _responseCreatedAt) public responseCreatedAt;
mapping(bytes32 _responseId => uint256 _responseCreatedAt) public responseCreatedAt;

/// @inheritdoc IOracle
mapping(bytes32 _id => uint256 _disputeCreatedAt) public disputeCreatedAt;
mapping(bytes32 _disputeId => uint256 _disputeCreatedAt) public disputeCreatedAt;

/// @inheritdoc IOracle
mapping(bytes32 _responseId => bytes32 _disputeId) public disputeOf;
Expand All @@ -35,7 +35,7 @@ contract Oracle is IOracle, OracleAccessController {
mapping(bytes32 _disputeId => DisputeStatus _status) public disputeStatus;

/// @inheritdoc IOracle
mapping(uint256 _requestNumber => bytes32 _id) public nonceToRequestId;
mapping(uint256 _nonce => bytes32 _requestId) public nonceToRequestId;

/// @inheritdoc IOracle
mapping(bytes32 _requestId => bytes32 _finalizedResponseId) public finalizedResponseId;
Expand Down Expand Up @@ -111,6 +111,7 @@ contract Oracle is IOracle, OracleAccessController {
AccessControl[] calldata _accessControl
) external returns (bytes32[] memory _batchRequestsIds) {
uint256 _requestsAmount = _requestsData.length;

_batchRequestsIds = new bytes32[](_requestsAmount);

for (uint256 _i; _i < _requestsAmount;) {
Expand Down

0 comments on commit 6231e6a

Please sign in to comment.