Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: entrypoints #144

Closed
wants to merge 24 commits into from
Closed

feat: entrypoints #144

wants to merge 24 commits into from

Conversation

hexshire
Copy link
Member

No description provided.

address indexed target,
uint256 indexed messageNonce,
address sender,
bytes message,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit: entrypoint prior to message such that all fixed length members come first. Makes it a bit easier to decode

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hamdi! Good catch, we’ve already made the changes. Thanks for the feedback!

@0xDiscotech 0xDiscotech marked this pull request as ready for review December 18, 2024 01:38
@hexshire
Copy link
Member Author

ethereum-optimism#13456

@hexshire hexshire closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants