-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix checkpoint filename for the PyTorch backend #1585
Conversation
Signed-off-by: Jinzhe Zeng <[email protected]>
WalkthroughWalkthroughThe modification in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant run_train_dp
participant CheckpointHandler
User->>run_train_dp: Call function with model checkpoint
run_train_dp->>run_train_dp: Determine checkpoint suffix based on file
alt Suffix is `.pb`
run_train_dp->>CheckpointHandler: Set suffix to `.pb`
else Suffix is `.pth`
run_train_dp->>CheckpointHandler: Set suffix to `.pth`
end
CheckpointHandler-->>run_train_dp: Checkpoint suffix set
run_train_dp-->>User: Continue training process
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #1585 +/- ##
==========================================
- Coverage 49.59% 49.59% -0.01%
==========================================
Files 83 83
Lines 14844 14849 +5
==========================================
+ Hits 7362 7364 +2
- Misses 7482 7485 +3 ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit
.pb
and.pth
).