fix: fix dtype of keywords_high_multiplicity

[njzjz]

which should have the same dtype as keywords.

Summary by CodeRabbit

• Improvements
  • Enhanced flexibility in configuration by allowing keywords_high_multiplicity to accept both strings and lists of strings.

[coderabbitai]

Walkthrough

Walkthrough

The fp_style_gaussian_args function within the dpgen/generator/arginfo.py file has been updated to accept the keywords_high_multiplicity argument as either a string or a list of strings. This enhances the flexibility of the function's input handling.

Changes

File	Change Summary
dpgen/generator/arginfo.py	Updated the keywords_high_multiplicity argument in the fp_style_gaussian_args function from type str to [str, list[str]].

Sequence Diagram(s)

The changes are too simple to warrant a sequence diagram as they primarily involve a type update for a function argument without altering control flow or adding new features.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 30bc1e5 and b5e477c.

Files selected for processing (1)

• dpgen/generator/arginfo.py (1 hunks)

Additional comments not posted (2)

dpgen/generator/arginfo.py (2)

712-714: LGTM!

The code changes are approved.

---

712-714: Verify the type annotation change for keywords_high_multiplicity.

The change allows keywords_high_multiplicity to accept both str and list[str] types. Ensure that this change is correctly reflected in the function's usage and documentation.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)

dpgen/generator/arginfo.py (1)

714-714: Ensure that the documentation reflects the new type.

The documentation for keywords_high_multiplicity should clearly state that it can accept both str and list[str].

- "Keywords for points with multiple raicals. `multiplicity` should be `auto`. If not set, fallback to normal keywords."
+ "Keywords for points with multiple radicals. `multiplicity` should be `auto`. If not set, fallback to normal keywords. Accepts both `str` and `list[str]`."

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.59%. Comparing base (30bc1e5) to head (b5e477c).
Report is 29 commits behind head on devel.

Additional details and impacted files

@@           Coverage Diff           @@
##            devel    #1582   +/-   ##
=======================================
  Coverage   49.59%   49.59%           
=======================================
  Files          83       83           
  Lines       14844    14844           
=======================================
  Hits         7362     7362           
  Misses       7482     7482           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.