-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dpdata label system read ase db file #115
base: devel
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add dpdata/ase
under this line
Lines 27 to 40 in f150dd1
packages=['dpdata', | |
'dpdata/vasp', | |
'dpdata/lammps', | |
'dpdata/md', | |
'dpdata/deepmd', | |
'dpdata/qe', | |
'dpdata/siesta', | |
'dpdata/gaussian', | |
'dpdata/cp2k', | |
'dpdata/xyz', | |
'dpdata/pwmat', | |
'dpdata/amber', | |
'dpdata/fhi_aims', | |
'dpdata/gromacs' |
documentation and unittest are required. |
'dpdata/xyz', | ||
'dpdata/pwmat', | ||
'dpdata/amber', | ||
'dpdata/fhi_aims', | ||
'dpdata/gromacs'], | ||
'dpdata/gromacs', | ||
'dpdata/ase' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to use another directory name instead of ase
, otherwise it will be conflict with the ase
package when you import ase
package in this directory.
Your change to the code should be based on branch "devel" rather than master. we do not want to merge some of changes on master into devel |
continue on deepmodeling#115
convert ase db to dpdata label system