fix duplicated elements in vasp/xml (#575)

Fix #480. #250 doesn't handle this situation. --------- Signed-off-by: Jinzhe Zeng <[email protected]>
deepmodeling · Nov 7, 2023 · e948661 · e948661
1 parent fb27e05
commit e948661
Show file tree

Hide file tree

Showing 3 changed files with 1,772 additions and 7 deletions.
diff --git a/dpdata/vasp/xml.py b/dpdata/vasp/xml.py
@@ -22,14 +22,14 @@ def analyze_atominfo(atominfo_xml):
     check_name(atominfo_xml.find("array"), "atoms")
     eles = []
     types = []
+    visited = set()
     for ii in atominfo_xml.find("array").find("set"):
-        eles.append(ii.findall("c")[0].text.strip())
-        types.append(int(ii.findall("c")[1].text))
-    uniq_ele = []
-    for ii in eles:
-        if ii not in uniq_ele:
-            uniq_ele.append(ii)
-    return uniq_ele, types
+        atom_type = int(ii.findall("c")[1].text)
+        if atom_type not in visited:
+            eles.append(ii.findall("c")[0].text.strip())
+            visited.add(atom_type)
+        types.append(atom_type)
+    return eles, types
 
 
 def analyze_calculation(cc):