Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu customizations in mobile #132

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Fix menu customizations in mobile #132

merged 3 commits into from
Jul 30, 2024

Conversation

andreslucena
Copy link
Member

With #13025 we changed the mobile menu, as we needed a bit more control on which elements we display there.

As this application has some customizations regarding this menu, we need to implement those customizations in this new mobile menu.

This PR fixes this customization in the mobile view.

Testing

  1. Run the seeds, so you have the customized Organization name and menu in the desktop view
  2. Resize, so you have a mobile menu
  3. (Before the patch) see that you have the non-customized menu
  4. (After the patch) see that you have the customized menu

Screenshots

Before

imatge

After

imatge

Copy link
Member

@fblupi fblupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@fblupi fblupi merged commit 4e45449 into master Jul 30, 2024
1 check passed
@fblupi fblupi deleted the fix/menu-customizations branch July 30, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants