Remove leftovers from proposals' states overrides #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fblupi
approved these changes
Jul 25, 2024
|
Are these custom states in the database? As far as I remember the overrides that I made were 100% for helpers/strings/cell. |
fblupi
approved these changes
Jul 29, 2024
Just to leave it here, but I think this behavior that you've seen was related to the bug described at #13219, so I think we don't need to add these i18n strings. Maybe when we deploy the next RC can you check out if the bug is still there? |
Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #121 we have added some overrides, that we removed most of them we we've done the v0.29.0.rc3 update as this feature (changing proposal states strings and colors) is native now.
This PR removes a few leftovers from it.