Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: camera reel capture view shortcuts panel is missing key icons #3033

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

popuz
Copy link
Collaborator

@popuz popuz commented Dec 23, 2024

What does this PR change?

Somehow reference for outline icon was lost on the prefab, so I re-added it with slight modifications:

  • Re-organized prefab structure for Shortcuts panel
  • Re-added outline for shortcut keys
  • Added shortcuts for tilting and right mouse click

How to test the changes?

  1. Launch the explorer with debug and camera reel CLI args
  2. Open Screencapture view and open shortcuts panel there
  3. Verify that all b

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copy link
Contributor

github-actions bot commented Dec 23, 2024

badge

Build failed! Check the logs to see what went wrong

@DafGreco
Copy link
Collaborator

DafGreco commented Dec 24, 2024

Follow up comment after checking the First iteration of this PR :

⚠️ Seems that the hotkeys are not fitting well on the square of the instructions but they seem to look properly without white assets.

Things verified on windows :

  • Camera functionality
  • Hotkeys instructions
  • Set as public toggle and functionality
  • Full Storage in the camera reel
  • Teleport through camera reel
  • Profile section album

Sanity check performed :

  • Emotes
  • Backpack
  • Teleport through camera reel , command and Map
  • Places visited : Casa roustan , The inn , Dollhouse , the seed
  • Metadynelabs
  • On boarding ⚠️ Seems that during this PR the images on the end of the on boarding took a lot of time to load in order to move out and teleport to another place (screenshot attached of the loaded portals) already reported on github
  • Side bar

Evidence:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants