Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: /goto crowd command and refactor #3032

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

mihakrajnc
Copy link
Contributor

What does this PR change?

This PR adds the /goto crowd command with a refactor to the commands system (removing regex usage primarily). Additionally the output of /help will now include debug only commands when we are in debug mode.

How to test the changes?

  1. Launch the explorer
  2. Type in /goto crowd - should teleport you to the most crowded spot in Genesis
  3. Check that all other commands work
  4. Ensure that debug only commands (like loadpx, killpx, debug) are only printed in /help when running the client with --debug.

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copy link
Contributor

github-actions bot commented Dec 23, 2024

badge

Build failed! Check the logs to see what went wrong

Copy link
Collaborator

@fcolarich fcolarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactor!! nice job!! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants