Fix: re-logging while on GC causes failed login state #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below. |
anicalbano
requested review from
Ludmilafantaniella
and removed request for
anicalbano
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This solves this issue for now: #2990
When we are in GC and logout and then login again, we get a failed login state because we are already in the same realm we are trying to re-load.
I added as a quick fix a flag to ignore this check when doing it from the logout flow, but the correct fix is to properly organize the re-login operation.
So this will be a stopgap solution until I can do that properly and make sure all works correctly.
...
How to test the changes?
Log into the client, then logout and try to login again with any user (same or different). You should log properly and not be "kicked" out to the login screen as it was happening.