-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: asset bundle fallback #3008
Open
dalkia
wants to merge
8
commits into
dev
Choose a base branch
from
feat/asset-bundle-fallback
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below. |
dalkia
force-pushed
the
feat/asset-bundle-fallback
branch
from
December 16, 2024 18:07
7ecb4ca
to
0328c41
Compare
Ludmilafantaniella
requested review from
Ludmilafantaniella
and removed request for
DafGreco
December 18, 2024 13:57
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here’s what we validated during the process:
- Fall-back to the most recent outdated scene bundle: ✅ Passed successfully.
- Correct bundle retrieval for updated scenes: ✅ Also passed without issues.
- Validate local cache removal for non-active scenes: ❌ This point failed because the reload functionality hasn’t been implemented yet, and Juani confirmed it won’t be ready in time.
Additional Notes:
- The bug we encountered was related to the back-end and didn’t affect our testing results. 182 (dapps)
- We couldn’t test the unpublish flow, meaning the modification of scene pointers (shrink or expand) still needs to be validated.
Untitled.video.-.Made.with.Clipchamp.mp4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
How to test the changes?
zone
.--dclenv zone
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md