Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADR-183: Favorite places #188

Merged
merged 22 commits into from
Mar 7, 2023
Merged

ADR-183: Favorite places #188

merged 22 commits into from
Mar 7, 2023

Conversation

davidejensen
Copy link
Member

Required by #183

@davidejensen davidejensen self-assigned this Feb 7, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 7, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: abf3710
Status: ✅  Deploy successful!
Preview URL: https://238c3d3d.adr-cvq.pages.dev
Branch Preview URL: https://adr-favorite-places.adr-cvq.pages.dev

View logs

@davidejensen davidejensen marked this pull request as ready for review February 8, 2023 16:08
@davidejensen davidejensen requested a review from a team as a code owner February 8, 2023 16:08
@davidejensen davidejensen requested a review from menduz February 8, 2023 16:08
menduz
menduz requested changes Feb 8, 2023
View reviewed changes
content/ADR-188-favorite-places.md Outdated Show resolved Hide resolved
content/ADR-188-favorite-places.md Outdated Show resolved Hide resolved
content/ADR-188-favorite-places.md Outdated Show resolved Hide resolved
content/ADR-188-favorite-places.md Outdated Show resolved Hide resolved
content/ADR-188-favorite-places.md Outdated Show resolved Hide resolved
@davidejensen @menduz
Updated ADR number
174acde 
Co-authored-by: menduz <[email protected]>
Signed-off-by: davidejensen <[email protected]>
@davidejensen davidejensen changed the title ADR-188: Favorite places ADR-183: Favorite places Feb 8, 2023
marianogoldman
marianogoldman reviewed Feb 8, 2023
View reviewed changes
content/ADR-183-favorite-places.md Outdated Show resolved Hide resolved
content/ADR-183-favorite-places.md Outdated Show resolved Hide resolved
content/ADR-183-favorite-places.md Outdated Show resolved Hide resolved
@nachomazzara
Copy link
Contributor

nachomazzara commented Feb 17, 2023 •
edited
Loading

Leaving this here as it seems that I used the wrong place 😆

#183 (comment)

Thanks @davidejensen!
Chances are that I'm a little bit away from the final shape/objective we want for places, but if we choose to store it in the places' server. Is it ok to have in the reference client (Unity) a dependency on a "private API" (Places API)? CC @eordano @olavra

davidejensen and others added 7 commits March 1, 2023 08:57
@davidejensen davidejensen requested a review from menduz March 1, 2023 14:31
menduz
menduz approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@menduz menduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor editorial suggestions for first-time readers

content/ADR-183-favorite-places.md Outdated Show resolved Hide resolved
content/ADR-183-favorite-places.md Outdated Show resolved Hide resolved
content/ADR-183-favorite-places.md Outdated Show resolved Hide resolved
@menduz menduz merged commit a7052ae into main Mar 7, 2023
@menduz menduz deleted the adr/favorite-places branch March 7, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidota guidota guidota left review comments

@marianogoldman marianogoldman marianogoldman left review comments

@menduz menduz menduz approved these changes

Assignees

@davidejensen davidejensen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@davidejensen @nachomazzara @menduz @marianogoldman @guidota @LautaroPetaccio