[FIX] 디스코드 알림 기능 수정 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 디스코드 알림 이미지 수정 - 디스코드 알림 이름 수정 - 디스코드 알림 임베드 제목, 임베드 내용 맞변경
Test Results12 tests 12 ✅ 0s ⏱️ Results for commit 6e3ff80. |
📝 Test Coverage Report
|
coli-geonwoo
approved these changes
Dec 27, 2024
| @@ -24,8 +22,8 @@ jobs: | |||
| echo "PR_URL=${{ github.event.issue.pull_request.html_url }}" >> $GITHUB_ENV | |||
| echo "AUTHOR_URL=${{ github.event.comment.user.avatar_url }}" >> $GITHUB_ENV | |||
| echo "CONTENT=$(echo '${{ github.event.comment.body }}' | base64 -w 0)" >> $GITHUB_ENV | |||
| echo "COMMENT_BODY=${{ github.event.issue.title }}" >> $GITHUB_ENV | |||
| echo "TITLE=Pull Request" >> $GITHUB_ENV | |||
| echo "TITLE=${{ github.event.issue.title }}" >> $GITHUB_ENV | |||
There was a problem hiding this comment.
✅ 이슈 & PR 제목을 title로 하고 comment_body로 구분해주는 거군요!
| username: $username, | ||
| avatar_url: $avatar_url, | ||
| username: $author_name, | ||
| avatar_url: $author_url, |
There was a problem hiding this comment.
✅ $author_url은 작성자 프로필 이미지를 가져오는 변수명으로 생각되네요! 좋아요.
unifolio0
approved these changes
Dec 27, 2024
| @@ -24,8 +22,8 @@ jobs: | |||
| echo "PR_URL=${{ github.event.issue.pull_request.html_url }}" >> $GITHUB_ENV | |||
| echo "AUTHOR_URL=${{ github.event.comment.user.avatar_url }}" >> $GITHUB_ENV | |||
| echo "CONTENT=$(echo '${{ github.event.comment.body }}' | base64 -w 0)" >> $GITHUB_ENV | |||
| echo "COMMENT_BODY=${{ github.event.issue.title }}" >> $GITHUB_ENV | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 연관 이슈
closed #36
🗣️ 리뷰 요구사항 (선택)