[CHORE] 커스텀 에러 및 핸들러 구현 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
December 15, 2024 23:34
Closed
Test Results24 tests 24 ✅ 3s ⏱️ Results for commit 2a5a268. ♻️ This comment has been updated with latest results. |
📝 Test Coverage Report
|
leegwichan
reviewed
Dec 25, 2024
Comment on lines
+27
to
+30
| public ResponseEntity<ErrorResponse> handleBindingException(BindException exception) { | ||
| log.warn("message: {}", exception.getMessage()); | ||
| return toResponse(ClientErrorCode.FIELD_ERROR); | ||
| } |
There was a problem hiding this comment.
[질문] 전부 ResponseEntity를 사용하신 이유가 있나요?
There was a problem hiding this comment.
다른 PR에서도 말했지만
- controller위 추상화 준위에 reponseentity가 올바르다고 생각하는 점
- 확장에 용이하다는 점
- 정적 메서드 제공으로 휴먼에러 방지에 용이하고 가독성이 좋다는 점
을 이유로 선호해요. 목요일 회의 이후에 명확히 컨벤션 정하고 반영하겠습니다!
unifolio0
approved these changes
Dec 25, 2024
Comment on lines
7
to
8
| public enum ServerErrorCode implements ErrorCode { | ||
| INTERNAL_SERVER_ERROR(HttpStatus.INTERNAL_SERVER_ERROR, "서버 오류가 발생했습니다. 관리자에게 문의하세요."), |
added 2 commits
December 27, 2024 20:13
added 2 commits
December 27, 2024 20:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 연관 이슈
closed #28
🌟 Description
ErrorCode
ErrorCode : status와 메시지를 정의합니다. (땅콩 소스코드 참고했습니다 🥜 )
DTException : 최상위 abstract 클래스(status와 message를 필드로 가짐)
✨ 에러 핸들링 전략
🗣️ 리뷰 요구사항 (선택)
현재는 DTException의 존재 이유가 크게 느껴지지 않아서, abstract 클래스를 없애고 DTClientException은 필드로 ClientErrorCode를 DTServerException은 필드로 ServerErrorCode를 들고 있게 하는 건 어떨까요?
타입계층의 존재이유가 크게 없는 것 같아 여쭈어요.