Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Test Environment #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

sdwilsh
Copy link
Contributor

@sdwilsh sdwilsh commented Sep 8, 2022

This has GitHub Actions run with Python 3.9 and 3.10, the two versions that are supported by Home Assistant currently. It also updates pytest-homeassistant-custom-component to something much newer such that it actually finds working dependencies.

These two version of Python are what is currently supported by Home
Assistant, so the CI should run on them.
@sdwilsh
Copy link
Contributor Author

sdwilsh commented Sep 8, 2022

The tests are still going to fail, as there are two fixtures that they reference that simply do not exist. I'm not going to have time for a few days to debug them, but I've started some of that work in sdwilsh/fix-tests.

@dcramer
Copy link
Owner

dcramer commented Sep 8, 2022

@sdwilsh was that always the case? been so long since I wrote this, just kind of assumed the tests are valid

@sdwilsh
Copy link
Contributor Author

sdwilsh commented Sep 8, 2022

It looks like you nuked the two missing fixtures in 197697b, and that was the most recent commit to that directory, so it's never worked with GitHub code. Maybe you had it working locally (I've certainly done that before).

I can setup the integration now, and it finds the device, but no entities so there's more to debug with this. I'll try to get tests for whatever I get working so we don't break it in the future.

@dcramer
Copy link
Owner

dcramer commented Sep 8, 2022

@sdwilsh which system do you have? model number or something? i will have to check mine but when I was writing this I remember there being multiple systems

fwiw I believe I modeled the API somewhat dry initially off of another project, specifically this https://github.com/tagyoureit/homebridge-luxor

@sdwilsh
Copy link
Contributor Author

sdwilsh commented Sep 9, 2022

I honestly don't know, and their app isn't telling me anything terribly useful, I think (it says lux2 and what I assume is a serial number after a dash). I don't see anything helpful in emails with the contractor who installed it either, but I swear we discussed options somewhere.

Realistically, I'm not going to be able to dive into this for about two weeks, looking at my calendar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants