zkutils: auto remove the ZK docker container #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for the case where the test process is killed, leaving the ZK container running. It'll be great if `docker stop` can also remove the container as well.
|
The windows CI failure looks unrelated to this change. |
jdef
reviewed
Jul 24, 2018
| @@ -54,7 +54,9 @@ func StartZookeeper(opts ...func(*ZKConfig)) (*ZkControl, error) { | |||
|
|
|||
| // the container IP is not routable on Darwin, thus needs port | |||
| // mapping for the container. | |||
| hostConfig := &container.HostConfig{} | |||
| hostConfig := &container.HostConfig{ | |||
| AutoRemove: true, | |||
There was a problem hiding this comment.
instead of hard-coding this, maybe make it a field in ZKConfig and then you can configure it using a functional option. I'd like to avoid hard-coding new things here.
|
@jieyu What's the status of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zkutils: auto remove the ZK docker container
Checklist
Overview of Change
This is for the case where the test process is killed, leaving the ZK
container running. It'll be great if
docker stopcan also remove thecontainer as well.
Changelog [optional]
Affected Usage
ZK container will be auto removed if stopped.