-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix grants statements on materialized views #1267
base: main
Are you sure you want to change the base?
Conversation
Granting privileges on materialized views was failing because the generated SQL statement used the relation type `materialized_view` as part of the query instead of `materialized view` (with a space). This commit defines an override for this specific materialization in the and grant/revoke macros.
5712dcf
to
953deed
Compare
Hello @AcidFlow @VersusFacit @colin-rogers-dbt , could you please take a look at this PR? This is an issue that requires a custom workaround from us. This PR has been open for some time and the fix here would resolve this persistent issue. |
Hey @kubikb ! As a workaround if this PR does not get enough attention, what we did internally was to copy the two macros changed in this PR, to our dbt project macros directory. They will then take precedence over the one in the |
Apologies for the delay here, we do want to get this merged in but will likely look to extend our functional tests to cover this case here |
resolves #1268
Problem
Granting privileges on materialized views was failing because the generated SQL statement used the relation type
materialized_view
as part of the query instead ofmaterialized view
(with a space).Solution
This PR defines an override for this specific materialization in the and grant/revoke macros to fix the generated query.
Checklist