Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU Utilization in Containerized Environments: A Comprehensive Guide #25

Closed
wants to merge 4 commits into from

Conversation

JohnnieJnr
Copy link
Contributor

@JohnnieJnr JohnnieJnr commented Aug 20, 2024

/claim #8
/closed #8

Pull Request Template

Writer's Checklist

  • Follow Writing Structure

    • I have used more than two H2 subtitles to organize content.
    • Include an introduction with at least two paragraphs before the first H2 section.
    • Use bold, italic, underline, notes, quotes, TLDRs, and key points as needed.
    • Include code elements where appropriate.
    • Write the article in Markdown format.
  • Fact-Check

    • I have verified all facts and data points included in the article.
  • Assets

    • Save images in the /assets folder.
    • Follow naming conventions: YYYYMMDD_title_of_the_article_IMG_NAME_NO.png.
  • Interlinking

  • Glossary/Definitions

    • Identify and mark new terms that could be added to the Definitions page.
  • Review and Edit

    • Read the article out loud to catch any awkward phrasing.
    • Run the draft through Grammarly or a similar tool to correct grammar and spelling errors.
    • Double-check adherence to the style guide and repository guidelines.

@nkkko
Copy link
Member

nkkko commented Aug 20, 2024

I can't review until you implement the checklist. Please read closely README. Some repeated problems from other PR's are present also. Current status of the article is 2.5/10. inadequate effort invested.

@JohnnieJnr
Copy link
Contributor Author

I'm sorry for making your work difficult. I thought the checklist was to be used by you in your review hence the reason I ignored it. I'm making the necessary corrections now.

Copy link
Member

@nkkko nkkko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this?

This is 5/10.

Some serious errors, especially regarding Daytona. User need to be able to use the code and run it.

Share the code on your github repo, create a starter-gpu repo with all needed files to create a GPU enabled workspace in Daytona

#### Cloning the nanoGPT Repository

Start by cloning the nanoGPT repository from GitHub:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using Daytona, daytona is cloning the repo adn creating workspace out of it inside the docker container

```

This Dockerfile sets up the environment required to run nanoGPT, including CUDA and PyTorch, which are essential for leveraging GPU resources.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where devcontainer? please add

Example command:

```bash
daytona run --gpus all nanogpt-gpu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is halucination?!

@mojafa
Copy link
Collaborator

mojafa commented Nov 13, 2024

@JohnnieJnr is this true?

Running nanoGPT in Daytona

Daytona is a container orchestration platform that simplifies running containerized applications, especially those requiring GPU support. To run nanoGPT in Daytona, follow these steps:

@mojafa
Copy link
Collaborator

mojafa commented Nov 13, 2024

Please close this PR and fix all the changes.
Create a new PR that matches the name of the issue:
GPU Utilization in Containerized Environments

@nkkko
Copy link
Member

nkkko commented Dec 2, 2024

@JohnnieJnr where are we with this?

@JohnnieJnr
Copy link
Contributor Author

@nkkko I'm working on rewriting the article. I'll submit the first revision by Thursday

@JohnnieJnr JohnnieJnr changed the title Gpu utilization GPU Utilization in Containerized Environments: A Comprehensive Guide Dec 4, 2024
@mojafa
Copy link
Collaborator

mojafa commented Dec 8, 2024

@JohnnieJnr you have attempted 2 other issues and have 2 other open PRs.

@mojafa
Copy link
Collaborator

mojafa commented Dec 21, 2024

@JohnnieJnr i'm closing this PR as you have another open one that is assigned to you.

@mojafa mojafa closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPU Utilization in Containerized Environments
3 participants