Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller monologo icon for Moodle ≥ 4.4. #123

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

lucaboesch
Copy link
Contributor

Hi @davosmith you might be interested in an icon for Moodle 4.4 and onwards. Lines are a little bit more thick to match better with other icons.

@davosmith
Copy link
Owner

You mention this icon specifically works with Moodle 4.4 and above - is there an issue with using it in earlier versions of Moodle?

I ask because I currently have a Moodle 4.1 - 4.4 branch; ideally I'd prefer not to have to split out a separate branch just for Moodle 4.4

@lucaboesch
Copy link
Contributor Author

lucaboesch commented May 27, 2024

Hi Davo!
image
I think technically it wouldn't complain. Only that the icon in fact became somewhat smaller (in the above example the assignment activity icon) in Moodle 4.4 (4.3 is on the left hand side). And not sure it would then look worse in 4.1, 4.2 and 4.3.

@davosmith davosmith merged commit d5c9cd3 into davosmith:master Jun 3, 2024
4 checks passed
@davosmith
Copy link
Owner

Thanks I'll merge it in and, hopefully, it will look OK on all versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants