Add more SDR record types #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datdenkikniet
force-pushed
the
fru
branch
2 times, most recently
from
0e2f407 to
17966b8
Compare
|
@richardstephens I've done some extra tinkering on this, and landed on just putting the relevant things in traits instead. I think it's good enough (for now, at least), since most of the relevant stuff is captured. I also added more sophisticated parser errors for all items, which should bubble up correctly now :) If you have time, I would appreciate it if you could put some eyes on it :) |
datdenkikniet
force-pushed
the
fru
branch
2 times, most recently
from
866618f to
0dfaec6
Compare
|
Looks good. Our fork has fallen a bit behind, so I'll make time over the next couple of days to bring it up to latest main + these changes and check that everything still works. Thanks for making progress on my changes 😄 |
datdenkikniet
force-pushed
the
fru
branch
4 times, most recently
from
7ff7907 to
6db631a
Compare
This change also renames some structs to better reflect what they actually represent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #10.
Closes #10