Don't crash on startup with no config, closes #20

datasette · Sep 1, 2024 · 46b5381 · 46b5381
1 parent 5dfbc9e
commit 46b5381
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/datasette_acl/__init__.py b/datasette_acl/__init__.py
@@ -159,7 +159,7 @@ async def inner():
             [{"name": n} for n in datasette.permissions.keys()],
         )
         # And any dynamic groups
-        config = datasette.plugin_config("datasette-acl")
+        config = datasette.plugin_config("datasette-acl") or {}
         groups = config.get("dynamic-groups")
         if groups:
             await db.execute_write_many(
@@ -199,7 +199,7 @@ async def update_dynamic_groups(datasette, actor, skip_cache=False):
         # Don't do this more than once a second per actor
         return
     one_second_cache.set(actor["id"], 1)
-    config = datasette.plugin_config("datasette-acl")
+    config = datasette.plugin_config("datasette-acl") or {}
     groups = config.get("dynamic-groups")
     if not groups:
         return

diff --git a/tests/test_startup.py b/tests/test_startup.py
@@ -0,0 +1,9 @@
+from datasette.app import Datasette
+import pytest
+
+
+@pytest.mark.asyncio
+async def test_can_startup_with_no_configuration():
+    datasette = Datasette()
+    await datasette.invoke_startup()
+    assert (await datasette.client.get("/")).status_code == 200