Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for tr.yml #1048

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Update for tr.yml #1048

merged 1 commit into from
Dec 28, 2023

Conversation

CengizhanAral
Copy link
Contributor

I added more data for the tr.yml file.

Added more first_name, last_name, job, free_email, domain_suffix, city_name, country and publisher.
Added Turkish version for weather.yml, color.yml, coin.yml and university.yml.
Changed to correct safe_email, default_country.
Copy link

what-the-diff bot commented Dec 27, 2023

PR Summary

  • Enhancement to Turkish locale file
    The Turkish language and locale information (src/main/resources/tr.yml) has been comprehensively updated in this Pull Request.

  • Addition of Turkish Names
    Fresh batch of first and last Turkish names have been added to the file to enhance the diversity and accuracy of fake data generation.

  • Inclusion of New Job Titles
    Several job titles have been added to the file to broaden the range of fake profiles that can be created.

  • Introduction of More Email Domains
    Many more email domains, both free and safe, have been included in this update, thereby expanding the potential variety of email addresses.

  • Addition of Turkish Area Codes and City Names
    The update includes the introduction of numerous Turkish area codes and city names. This allows for a more realistic and diverse set of locations within Turkey for the generated profiles.

  • Update on Country Information
    Several new country names have been added, and the default country has been set to 'Türkiye' (Turkey in Turkish), enhancing the representation of this locale.

  • Inclusion of New Publishers and Weather Descriptions
    The addition of new publishers and various weather descriptions enriches the range of possible scenarios and character profiles that can be generated.

  • Temperature Units, Color Names, Coin Flips, and Degree Names
    Various new temperature units and color names have been added. Options for flipping a coin and academic degree names have also been included, adding yet another layer of depth.

  • Expanded University Suffixes
    This update has brought in a variety of suffixes for universities, which greatly broadens the range of academic institution names that can be generated.

These modification steps up the authenticity of the dummy data created, thereby enhancing the validation process and thus, product quality.

@bodiam
Copy link
Contributor

bodiam commented Dec 27, 2023

Nice work! Thanks for this addition!

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (469144f) 92.33% compared to head (36e5009) 92.35%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1048      +/-   ##
============================================
+ Coverage     92.33%   92.35%   +0.01%     
- Complexity     2766     2768       +2     
============================================
  Files           291      291              
  Lines          5543     5543              
  Branches        600      600              
============================================
+ Hits           5118     5119       +1     
  Misses          272      272              
+ Partials        153      152       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bodiam bodiam merged commit 7da5974 into datafaker-net:main Dec 28, 2023
7 checks passed
@kingthorin
Copy link
Collaborator

This is great, thanks 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants