Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When importing in dbt format, add the dbt unique information as a datacontract unique field #558

Merged
merged 7 commits into from
Dec 21, 2024
Merged

When importing in dbt format, add the dbt unique information as a datacontract unique field #558

merged 7 commits into from
Dec 21, 2024

Conversation

syou6162
Copy link
Contributor

@syou6162 syou6162 commented Dec 20, 2024 •
edited
Loading

I made the same modifications to unique as I did to #547 (ref: #542). If it looks good, I'll send a pull request for primary_key with the same modifications 👍

  • Tests pass
  • ruff format
  • README.md updated (if relevant)
  •  CHANGELOG.md entry added

@syou6162 syou6162 marked this pull request as ready for review December 20, 2024 15:47
@simonharrer simonharrer merged commit ff4813c into datacontract:main Dec 21, 2024
5 checks passed
@syou6162 syou6162 deleted the feature/enable_import_unique_dbt branch December 21, 2024 14:47
@syou6162 syou6162 mentioned this pull request Dec 22, 2024
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syou6162 @simonharrer