Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ganache to geth #24

Merged
merged 7 commits into from
Mar 6, 2024
Merged

Conversation

dongrie
Copy link

@dongrie dongrie commented Feb 13, 2024

Changed the Ethereum chain from ganache to geth

Signed-off-by: Dongri Jin <[email protected]>
@dongrie dongrie requested a review from siburu February 13, 2024 04:08
Signed-off-by: Dongri Jin <[email protected]>
Signed-off-by: Dongri Jin <[email protected]>
Copy link
Contributor

@siburu siburu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongrie I added some comments

.github/workflows/v0.4-build.yml Outdated Show resolved Hide resolved
tests/chains/ethereum/geth/Dockerfile Outdated Show resolved Hide resolved
tests/chains/ethereum/geth/run.sh Outdated Show resolved Hide resolved
* Change relay-chain, Yui-relayer version
* Change ibc-solidity version
* Fix ethereum run command

Signed-off-by: Dongri Jin <[email protected]>
@dongrie dongrie requested a review from siburu February 29, 2024 11:10
dongrie added 2 commits March 1, 2024 17:43
* Remove save-contract-address
* Remove NETWORK ID
* Use latest version of ibc-solidity, yui-relayer

Signed-off-by: Dongri Jin <[email protected]>
@dongrie dongrie mentioned this pull request Mar 1, 2024
Copy link
Contributor

@siburu siburu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongrie I put some comments and questions.

tests/chains/ethereum/contracts/contracts/.gitkeep Outdated Show resolved Hide resolved
tests/chains/ethereum/contracts/package.json Outdated Show resolved Hide resolved
tests/chains/ethereum/contracts/scripts/deploy.js Outdated Show resolved Hide resolved
* Add license
* Remove exports.deployIBC

Signed-off-by: Dongri Jin <[email protected]>
@dongrie dongrie requested a review from siburu March 6, 2024 03:16
Copy link
Contributor

@siburu siburu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongrie LGTM, thank you!

@siburu siburu merged commit 6606fdc into datachainlab:v0.4 Mar 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants