-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ganache to geth #24
Conversation
Signed-off-by: Dongri Jin <[email protected]>
Signed-off-by: Dongri Jin <[email protected]>
Signed-off-by: Dongri Jin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dongrie I added some comments
* Change relay-chain, Yui-relayer version * Change ibc-solidity version * Fix ethereum run command Signed-off-by: Dongri Jin <[email protected]>
* Remove save-contract-address * Remove NETWORK ID * Use latest version of ibc-solidity, yui-relayer Signed-off-by: Dongri Jin <[email protected]>
Signed-off-by: Dongri Jin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dongrie I put some comments and questions.
* Add license * Remove exports.deployIBC Signed-off-by: Dongri Jin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dongrie LGTM, thank you!
Changed the Ethereum chain from ganache to geth