Fix nightly CI builds #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR breaks backwards compatibility for databrickslabs/blueprint downstream. See build logs for more details. Running from downstreams #8 |
|
✅ 27/27 passed, 3 skipped, 2m1s total Running from acceptance #48 |
nfx
added a commit
that referenced
this pull request
Sep 18, 2024
* Fixed nightly CI builds ([#40](#40)). In this release, we have removed the `no-cheat` GitHub Actions workflow that checked for disables pylint directives in new code. We have also updated the pytest requirement version to ~8.3.3 and added badges for Python version support and lines of code to the README file. The `permissions.py` file in the `databricks/labs/pytester/fixtures` directory has been updated to fix nightly CI builds by improving import statements and updating types. The `SqlPermissionLevel` class has been imported from the `databricks.sdk.service.sql` module, and an existing test case has been updated to use this new permission level for SQL-specific queries. Additionally, we have updated the version constraints for three dependencies in the `pyproject.toml` file to allow for more flexibility in selecting compatible library versions. These changes may simplify the project's GitHub Actions workflows, reduce maintenance overhead, and enhance the testing process and code quality.
Merged
nfx
added a commit
that referenced
this pull request
Sep 18, 2024
* Fixed nightly CI builds ([#40](#40)). In this release, we have removed the `no-cheat` GitHub Actions workflow that checked for disables pylint directives in new code. We have also updated the pytest requirement version to ~8.3.3 and added badges for Python version support and lines of code to the README file. The `permissions.py` file in the `databricks/labs/pytester/fixtures` directory has been updated to fix nightly CI builds by improving import statements and updating types. The `SqlPermissionLevel` class has been imported from the `databricks.sdk.service.sql` module, and an existing test case has been updated to use this new permission level for SQL-specific queries. Additionally, we have updated the version constraints for three dependencies in the `pyproject.toml` file to allow for more flexibility in selecting compatible library versions. These changes may simplify the project's GitHub Actions workflows, reduce maintenance overhead, and enhance the testing process and code quality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.