-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable debugging integration tests in VS Code #2053
Conversation
Could you link the PR that caused the issue explicitly here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shreyas-goenka The entry point always was acc.WorkspaceTest
.
Tests that didn't use that entry point were never debuggable.
Instead of applying this everywhere, I recommend using the acc.WorkspaceTest
wrapper in test where it is applicable to make easy debugging possible.
@pietern The problem I am trying to workaround is the
Since the main entry point runs before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see.
Then please include the isInDebug
-equivalent check to the main function. Then nothing else needs to change and we don't inadvertently load a workspace profile for an account-level test, or mix UC and non-UC.
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
@shreyas-goenka Please include a backlink to the PR that added this to the PR summary for posterity. |
Changes
This PR adds back debugging functionality that was lost during migration to
internal.Main
as an entry point for integration tests.The PR that caused the regression: #2009. Specifically the addition of internal.Main as the entrypoint for all integration tests.
Tests
Manually, by trying to debug a test.