Add 'experimental/python' support #2052
Conversation
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
| @@ -441,9 +547,9 @@ func createInitOverrideVisitor(ctx context.Context) merge.OverrideVisitor { | |||
| } | |||
|
|
|||
| func isOmitemptyDelete(left dyn.Value) bool { | |||
| // PyDABs can omit empty sequences/mappings in output, because we don't track them as optional, | |||
| // Python can omit empty sequences/mappings in output, because we don't track them as optional, | |||
There was a problem hiding this comment.
I find the original sentence more clear, "Python can omit empty sequences/mappings in output" does not make sense, as I assume Python is CPython binary.
There was a problem hiding this comment.
👍 We are getting rid of "PyDABs" name, so we can't use it anymore. I've rephrased it the same way as it was in the unit test.
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
| "pattern": "\\$\\{(var(\\.[a-zA-Z]+([-_]?[a-zA-Z0-9]+)*(\\[[0-9]+\\])*)+)\\}" | ||
| } | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Please execute "make schema" to update this.
| } | ||
|
|
||
| // PyDABs is deprecated use Python instead |
There was a problem hiding this comment.
Nit: deprecation should also be mentioned in the field above
| @@ -29,6 +30,7 @@ import ( | |||
| "github.com/databricks/cli/libs/process" | |||
| ) | |||
|
|
|||
| // phase is a phase of the Python mutator. | |||
There was a problem hiding this comment.
Nit: this doesn't really help understand the field; the above is what the code already says.
| } | ||
|
|
||
| return *b.Config.Experimental | ||
| pydabsEnabled := !reflect.DeepEqual(experimental.PyDABs, config.PyDABs{}) |
There was a problem hiding this comment.
I'm not sure I'm happy with the reflect call here. But I can see how a maintainable alternative is difficult to pull off. Could you add a comment as to why reflection is used inline for maintainers?
## Changes I noticed a diff in the schema in #2052. This check should be performed automatically. ## Tests This PR includes a commit that changes the schema to check that the workflow actually fails.
Changes
Add
experimental/pythonsection replacingexperimental/pydabs.Add 2 new mutators into existing pipeline:
ApplyPythonMutator(load_resources)- loads resources from Python codeApplyPythonMutator(apply_mutators)- transforms existing resources defined in Python/YAMLExample:
Tests
Unit tests and manually