Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove NodeIdEssential and NodeEssential traits #1276

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Dec 17, 2024

Changelog

Refactor: remove NodeIdEssential and NodeEssential traits

These two traits are used to simplify NodeId and Node constraints.
But with Optional* traits, these two are no longer needed.


This change is Reviewable

@drmingdrmer drmingdrmer requested a review from schreter December 17, 2024 03:45
schreter
schreter previously approved these changes Dec 17, 2024
Copy link
Collaborator

@schreter schreter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @drmingdrmer)


openraft/src/base/mod.rs line 62 at r1 (raw file):

/// A trait that combines all optional features.
#[doc(hidden)]

Do you really want to hide the docs? OTOH, other OptionalT docs are hidden as well.

Copy link
Member Author

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @drmingdrmer)


openraft/src/base/mod.rs line 62 at r1 (raw file):

Previously, schreter wrote…

Do you really want to hide the docs? OTOH, other OptionalT docs are hidden as well.

You're right. We should keep the OptionalT docs visible for consistency and better discoverability. I'll update the documentation settings.

These two traits are used to simplify NodeId and Node constraints.
But with `Optional*` traits, these two are no longer needed.
@drmingdrmer drmingdrmer merged commit c875b95 into databendlabs:main Dec 17, 2024
31 of 32 checks passed
@drmingdrmer drmingdrmer deleted the 174-node branch December 17, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants