Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: allow deprecated std::panic::PanicInfo in example tests #1188

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

SteveLauC
Copy link
Collaborator

@SteveLauC SteveLauC commented Jul 22, 2024

What does this PR do

Rust nightly 1.82 renamed std::panic::PanicInfo to std::panic::PanicHookInfo and mark the old name deprecated, this change is currently exclusive to nightly toolchain 1.82.0 and higher.

Based on our discussion, allow them.

Checklist

  • Updated guide with pertinent info (may not always apply).
  • Squash down commits to one or two logical commits which clearly describe the work you've done.
  • Unittest is a friend:)

This change is Reviewable

Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SteveLauC)

@drmingdrmer drmingdrmer merged commit fff880a into databendlabs:main Jul 22, 2024
31 checks passed
@SteveLauC SteveLauC deleted the test/fix_clippy branch July 22, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants