Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix a number of bugs in the spill config. #17103

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Dec 23, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

…g and update related logic

- Updated SpillConfig struct to use String instead of OsString for spill_local_disk_path.
- Adjusted conversion logic in cache_config_converters to handle the new String type.
- Added a test for spill configuration to ensure correct loading and path assignment.
- Minor improvements in error handling and temporary directory management.
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Dec 23, 2024
@forsaken628
Copy link
Collaborator Author

@forsaken628 forsaken628 requested a review from sundy-li December 23, 2024 14:00
@forsaken628 forsaken628 added this pull request to the merge queue Dec 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 24, 2024
@BohuTANG BohuTANG merged commit ee3e395 into databendlabs:main Dec 24, 2024
72 checks passed
@forsaken628 forsaken628 deleted the fix-spill-config branch December 25, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants