Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Serialize iceberg table inside engine options to reduce catalog requests #17049

Merged
merged 11 commits into from
Dec 23, 2024
Merged

refactor: Serialize iceberg table inside engine options to reduce catalog requests #17049

merged 11 commits into from
Dec 23, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Dec 13, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This PR will serialize iceberg table inside engine options to reduce catalog requests.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Dec 13, 2024
@Xuanwo Xuanwo added the ci-cloud Build docker image for cloud test label Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17049-d91eaca-1734097742

note: this image tag is only available for internal use,
please check the internal doc for more details.

@Xuanwo Xuanwo marked this pull request as draft December 13, 2024 15:04
@Xuanwo Xuanwo changed the title feat: Bump iceberg-rust to latest commit refactor: Serialize iceberg table inside engine options to reduce catalog requests Dec 14, 2024
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Dec 14, 2024
@Xuanwo Xuanwo added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Dec 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17049-9c956a7-1734174108

note: this image tag is only available for internal use,
please check the internal doc for more details.

@Xuanwo
Fix iceberg
1a67d4d 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Try optimize
7d7ac44 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Dec 16, 2024
@Xuanwo Xuanwo added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Dec 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17049-f7a7fc5-1734340183

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17049-6800aa7-1734341465

note: this image tag is only available for internal use,
please check the internal doc for more details.

@Xuanwo Xuanwo added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Dec 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17049-27c9d85-1734346223

note: this image tag is only available for internal use,
please check the internal doc for more details.

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 16, 2024

We didn't beat snowflake yet, but this PR is good enough to get merged.

@Xuanwo Xuanwo marked this pull request as ready for review December 16, 2024 14:58
@Xuanwo Xuanwo enabled auto-merge December 20, 2024 12:20
@Xuanwo Xuanwo added this pull request to the merge queue Dec 23, 2024
Merged via the queue into databendlabs:main with commit d379bc6 Dec 23, 2024
72 checks passed
@Xuanwo Xuanwo deleted the iceberg-test branch December 23, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngsofun youngsofun youngsofun approved these changes

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
ci-cloud Build docker image for cloud test pr-feature this PR introduces a new feature to the codebase pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xuanwo @sundy-li @youngsofun