Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refine cast variant to map #16691

Merged
merged 3 commits into from
Oct 27, 2024
Merged

refactor: refine cast variant to map #16691

merged 3 commits into from
Oct 27, 2024

Conversation

andylokandy
Copy link
Collaborator

@andylokandy andylokandy commented Oct 25, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Oct 25, 2024
@andylokandy andylokandy requested a review from b41sh October 27, 2024 09:40
@andylokandy andylokandy added this pull request to the merge queue Oct 27, 2024
Merged via the queue into databendlabs:main with commit 4f79166 Oct 27, 2024
72 checks passed
@andylokandy andylokandy deleted the dev12 branch October 27, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b41sh b41sh b41sh approved these changes

Assignees
No one assigned
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andylokandy @b41sh