nunique() #465
Merged
nunique() #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
force-pushed
the
nunique
branch
7 times, most recently
from
808ca28 to
c35581e
Compare
crusaderky
commented
Dec 6, 2023
Comment on lines
+1189
to
+1219
| if isinstance(uniqs, Index): | ||
| uniqs = uniqs.to_series() |
There was a problem hiding this comment.
phofl
reviewed
Dec 6, 2023
dask_expr/_collection.py
Outdated
| [ | ||
| col.nunique(dropna=dropna).to_series(col.name) | ||
| # for col in self # TODO not implemented | ||
| for col in (self.iloc[:, i] for i in range(self.shape[1])) |
There was a problem hiding this comment.
Can you write this as
self.iloc[:, I].(dropna=dropna).to_series(col.name) for i in range(len(self.columns))
?
There was a problem hiding this comment.
Could you merge #480?
phofl
approved these changes
Dec 6, 2023
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.