Add shift method
#461
Merged
Add shift method
#461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Dec 5, 2023
| after = 0 | ||
|
|
||
| def _divisions(self): | ||
| return self.frame.divisions |
There was a problem hiding this comment.
I think divisions change in shift? Not totally sure
There was a problem hiding this comment.
Hmm, not sure either. At least in dask.dataframe shift(..) doesn't change.
In [3]: df = pd.DataFrame({'v3': range(5), 'id6': [1, 2, 3, 2, 1]})
In [4]: ddf = dd.from_pandas(df, npartitions=2)
In [5]: ddf.shift(periods=2).divisions
Out[5]: (0, 3, 4)
In [6]: ddf.divisions
Out[6]: (0, 3, 4)
There was a problem hiding this comment.
you can do ddf.shift(periods=2).enforce_runtime_divisions() to see if the divisions are working as expected
phofl
reviewed
Dec 5, 2023
dask_expr/_expr.py
Outdated
|
|
||
| @functools.cached_property | ||
| def _meta(self): | ||
| return self.frame._meta |
milesgranger
force-pushed
the
milesgranger/shift
branch
from
39446e0 to
86aa3f5
Compare
milesgranger
force-pushed
the
milesgranger/shift
branch
from
86aa3f5 to
bac6c18
Compare
phofl
approved these changes
Dec 5, 2023
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.