Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add not_null and isnull #455

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Add not_null and isnull #455

merged 1 commit into from
Dec 5, 2023

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Dec 5, 2023

Anything I can test for the optimization flags? (mostly for training purposes, not necessarily for correctness)

@phofl
Copy link
Collaborator

phofl commented Dec 5, 2023

What we generally do is:

q = df.notnull()["a"]
expected = df["a"].notnull()

assert q.optimize()._name == expected.optimize()._name

Copy link
Collaborator

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

@phofl phofl merged commit 37f24cb into dask:main Dec 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants