Fix rejecting public keys of the form (0, y) #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veridise Audit ID 10
nalinbhardwaj
force-pushed
the
nibnalin/inf-point
branch
from
c96f864 to
e1406d3
Compare
dcposch
approved these changes
Sep 23, 2023
There was a problem hiding this comment.
Code LGTM and as far as I can tell the math matches
- Veridise's recommendation
- https://www.secg.org/sec1-v2.pdf
| @@ -105,7 +105,7 @@ contract P256Verifier { | |||
| uint256 x, | |||
| uint256 y | |||
| ) internal pure returns (bool) { | |||
| if (0 == x || x >= p || 0 == y || y >= p) { | |||
| if (x >= p || y >= p || (x == 0 && y == 0)) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Veridise Audit ID 10