Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: analytics at boot time #3759

Merged
merged 21 commits into from
Dec 23, 2024
Merged

fix: analytics at boot time #3759

merged 21 commits into from
Dec 23, 2024

Conversation

ilasw
Copy link
Contributor

@ilasw ilasw commented Nov 4, 2024

Changes

#3726 + fix for SSR that caused sidebar issue for logged users.

You can check the fix here: 540d67b

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://fix-analytics-boot.preview.app.daily.dev

Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Dec 23, 2024 7:58am
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Dec 23, 2024 7:58am

@ilasw ilasw marked this pull request as ready for review November 4, 2024 17:09
@ilasw ilasw requested a review from a team as a code owner November 4, 2024 17:09
@ilasw ilasw marked this pull request as draft November 5, 2024 07:27
Copy link
Member

@sshanzel sshanzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this now, but we will have to rigorously test this along with the auth flow before merging 🙏

@ilasw ilasw merged commit 5b55e3b into main Dec 23, 2024
10 checks passed
@ilasw ilasw deleted the fix-analytics-boot branch December 23, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants