Update download section and fix logo in navbar #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- rework download section - simplify StyledButton into one file - remove menu from Toolbar - add community banner - update background image - change all icons to rounded - update donation page - add new stuff to tsconfig
Looskie
requested changes
Aug 4, 2023
| <> | ||
| <Card> | ||
| <h1>Join the Community!</h1> | ||
| <div style={{ height: "3rem" }} /> |
There was a problem hiding this comment.
not super important for this component, but probably should still do for the sake of consistency:
inline styles should be a no-no, not only does it recreate a new object everytime its rendered its just slightly ugly.
| <DownloadTitle>{oldRelease.name}</DownloadTitle> | ||
| </StyledLink> | ||
| <DownloadSubtitle> | ||
| {getDate(oldRelease.published_at)} ꞏ{" "} |
There was a problem hiding this comment.
this should be in /components + should be capitalized (e.g Button.tsx)
| @@ -8,9 +8,10 @@ import { ThemeProvider as MUIThemeProvider } from "@mui/material"; | |||
| import { SWRConfig } from "swr"; | |||
| import { usePreferredTheme } from "../utils/hooks/usePreferredTheme"; | |||
| import { Inter } from "@next/font/google"; | |||
There was a problem hiding this comment.
yarn remove @next/font
Suggested change
| import { Inter } from "@next/font/google"; | |
| import { Inter } from "next/font/google"; |
| @@ -79,9 +80,7 @@ $$ $$ |$$ $$ |$$ | $$ |$$ |$$ |$$ $$ |$$ $$/ $$ $$/ | |||
|
|
|||
| return ( | |||
| <> | |||
| <Head> | |||
| <meta name="viewport" content="width=device-width" /> | |||
| </Head> | |||
There was a problem hiding this comment.
this should actually be in the <Head> tag in _document.tsx, not sure why its not
There was a problem hiding this comment.
it actually complains when it's in _document which is why i placed it inside _app
| "@mui/icons-material": "^5.14.3", | ||
| "@mui/material": "^5.14.3", | ||
| "@mui/styles": "^5.14.3", | ||
| "@next/font": "^13.4.12", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.