Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use string APPEND #192

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Use string APPEND #192

merged 1 commit into from
Aug 9, 2023

Conversation

mjp41
Copy link
Collaborator

@mjp41 mjp41 commented Aug 8, 2023

Fixes CMAKE_C?_FLAGS are not lists but strings #191

Fixes CMAKE_C?_FLAGS are not lists but strings daanx#191
Copy link

@RJVB RJVB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

(And thanks for picking this up)

@mjp41 mjp41 merged commit 4efabd0 into daanx:master Aug 9, 2023
@mjp41 mjp41 deleted the cmake branch August 9, 2023 16:25
derSteFfi pushed a commit to derSteFfi/mimalloc-bench that referenced this pull request Sep 7, 2023
Fixes CMAKE_C?_FLAGS are not lists but strings daanx#191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants