Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drafted Dockerfile to perform tests. #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Drafted Dockerfile to perform tests. #152

wants to merge 1 commit into from

Conversation

lhog
Copy link

@lhog lhog commented Jul 12, 2022

See #117

jvoisin
jvoisin requested changes Jul 12, 2022
View reviewed changes
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile
apt update && \
apt install cmake

RUN git clone https://github.com/daanx/mimalloc-bench
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git clone --depth=1 https://github.com/daanx/mimalloc-bench is a bit better.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, though the repo size is really minuscule. Can do if you prefer so.

docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
@lhog
Copy link
Author

lhog commented Aug 6, 2022

Any further feedback?

@jvoisin
Copy link
Collaborator

jvoisin commented Aug 10, 2022

I'm not using Docker at all, so I don't have much more to say :/

@lhog
Copy link
Author

lhog commented Aug 11, 2022

It's ok. Can you suggest how to use graph.py though? Some usage example would be nice to have.

@jvoisin
Copy link
Collaborator

jvoisin commented Aug 18, 2022

If memory serves, you can simply throw the output of a bench.sh run at it.

@lhog
Copy link
Author

lhog commented Aug 18, 2022

If my memory serves, last time I ran bench.sh it spit out a ton of .txt files, I tried to supply a few random ones to graph.py much to no avail. Can someone check the actual use? Like what files I need to feed to graph.py exactly, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvoisin jvoisin jvoisin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lhog @jvoisin