Remove Blog link 'run in Docker' - outdated content #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview Docker should no longer be listed in this table. |
|
MikeMcC399
force-pushed
the
remove/docker-blog
branch
from
14794c3 to
1e3d91b
Compare
|
I'm not sure if you monitor this repo. Could you please review this PR to clean up a reference to the 5 year old outdated blog regarding Docker usage? |
|
Please review! |
MikeMcC399
force-pushed
the
remove/docker-blog
branch
from
1e3d91b to
983f24a
Compare
|
Non-urgent, but would be good to clean up this 5 year old blog reference and get it removed from the examples. |
|
Please review/merge or reject. |
|
Closed due to lack of response. Since the PR is a simple one-line deletion, it is easily recreated if desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
README > Other Cypress Recipes contains a link to the outdated Blog article
Article
The blog article dated May 2, 2019 is based on legacy Cypress version
3.xand Cypress Docker images released before the Cypress Factory process was introduced in January 2023. Node.js12.xused in the examples reached end-of-life in April 2022. The repo bahmutov/demo-docker-cypress-included was last updated in January 2021.The linked example repo bahmutov/demo-docker-cypress-included no longer works (see below).
Video recording is no longer on by default.
The linked example repo cypress-io/cypress-example-docker-compose is archived and therefore is no longer supported and maintained.
The linked example repo bahmutov/cypress-open-from-docker-compose still works, however it is based on the legacy Cypress
4.0.2version.The
docker-composespecification ofversionis now obsolete.demo-docker-cypress-included
The repo bahmutov/demo-docker-cypress-included was last updated in January 2021.
./cy-run.shdo not work. Dependencies need to be installed.package-lock.jsonuses lockfilev1which causes a warning on Node.js18.x(the lowest currently supported version of Node.js).cypress/includedimages.cy-open.shdoes not work correctly on Ubuntu.cypress-example-docker-compose
The repo cypress-io/cypress-example-docker-compose was archived in February 2024. It uses the
cypress/base:16image, which is now unsupported due to Node.js16.xend-of-life. The demo does however still work and it uses Cypress13.6.4.cypress-open-from-docker-compose
The repo bahmutov/cypress-open-from-docker-compose was last updated in March 2020.
It uses the legacy
cypress/included:4.0.2image.Change
Remove the reference in README > Other Cypress Recipes to Blog article:
There are too many legacy, outdated, non-working, unsupported example and demo references in this blog article.
The repo https://github.com/cypress-io/cypress-docker-images contains up-to-date information on using Cypress Docker images and it is currently better able to provide working instructions using non-legacy versions of Cypress.