Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix player 1 controls affecting others in player selection #860

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

Kurtsley
Copy link
Contributor

Fixes #855

Prevents player one's controls from affecting other players in the player selection menu.

See comment:
#855 (comment)

src/prep.c Outdated Show resolved Hide resolved
@Kurtsley
Copy link
Contributor Author

So by checking if useMenuCmd returns more than 1 here, as per the suggestion, it essentially disables the default menu commands for all menus that have multiple players ex: equip menu. The default commands seem to work in all other menus. This functionality looks to be supported as the text at the bottom of most menus shows the default controls, but it switches to the mapped controls in the player select screen.

@cxong cxong merged commit 18f3647 into cxong:master Jun 20, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Player 1 controls can affect other players in character selection
2 participants