favoriteApps: initial implementation #1
Conversation
add submenu to add and remove favorite apps include cutie store for persistence add timer to differentiate short and long presses
|
|
||
| function saveFavoriteItem(name, iconPath, execCommand) { | ||
| let data = favoriteStore.data; | ||
| data["favoriteApp-" + name] = { "icon": iconPath, "command": execCommand }; |
There was a problem hiding this comment.
There is really no need to prefix it like this. Also, it would make sense the save the full js object (model).
There was a problem hiding this comment.
Got it .. I saw that the add data function only uses these 3 variables to create the deligate item, that's why I did the same.. should I be saving the whole object?
There was a problem hiding this comment.
Actually, the best way to do this imo would be to save the filename of the desktop file.
So, for example, when adding Firefox from /usr/share/applications/firefox-esr.desktop, the code should add "firefox-esr" to a JavaScript array.
With this, I would rename the store to settings and use data["favoriteApps"] as the array.
There was a problem hiding this comment.
Is the intension behind this is to have an extra page in the settings app to manage apps?
Also if we only save the file name then won't we need a lot more code to read the desktop file to get the icon and app name??
(Sorry if I miss understand your idea)
There was a problem hiding this comment.
Well, it is just redundant to store all information twice.
With this, it would be easier to remove uninstalled applications from favorites automatically.
In this case, it would be sane to move the desktop file parsing logic to a library.
There was a problem hiding this comment.
So the .desktop file is phrased and sent to libcutiestore then both all apps and favourite apps are loaded from this store?
There was a problem hiding this comment.
No, the desktop entries would be parsed on the fly. Of favorites, only the file name of the entry is saved. Then, cutie-home would parse the desktop file of this name.
There was a problem hiding this comment.
Oke, I think I understand now. will come back to this once I am done with cutie-home
There was a problem hiding this comment.
hi @erikinkinen how hard would it be to move desktop file parsing logic to a library.
replace onReleased with onPressAndHold remove timer move remove fav app menu to cutie-home
| @@ -80,6 +101,19 @@ CutieWindow { | |||
| elide: Text.ElideRight | |||
| horizontalAlignment: Text.AlignHCenter | |||
| } | |||
|
|
|||
| CutieStore { | |||
There was a problem hiding this comment.
Do not initialize this inside the delegate. That would cause it to initialize identical objects for each button which causes a heavy performance impact.
| width: launchAppGrid.cellWidth | ||
| height: launchAppGrid.cellHeight | ||
|
|
||
| property bool longPress: false |
There was a problem hiding this comment.
This is not used anymore as far as I can see.
| height: launchAppGrid.cellHeight | ||
|
|
||
| property bool longPress: false | ||
| property alias menu: menu |
There was a problem hiding this comment.
This should be necessary. The identifier menu should be available inside the delegate through the id property.
add submenu to add and remove favorite apps
include cutie store for persistence
add timer to differentiate short and long presses
Part 2 will be to implement a new panel in cutie home which requires a little bit more work