Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context Search Integration #61

Merged
merged 7 commits into from
Jun 19, 2024
Merged

Context Search Integration #61

merged 7 commits into from
Jun 19, 2024

Conversation

rathijitpapon
Copy link
Member

No description provided.

Copy link

linear bot commented Jun 18, 2024

@rathijitpapon rathijitpapon marked this pull request as draft June 18, 2024 06:40
@rathijitpapon rathijitpapon changed the title Context Search Integration [!WIP] Context Search Integration Jun 18, 2024
@rathijitpapon rathijitpapon changed the title [!WIP] Context Search Integration Context Search Integration Jun 19, 2024
@rathijitpapon rathijitpapon marked this pull request as ready for review June 19, 2024 10:49
Copy link
Contributor

@ivarflakstad ivarflakstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Feel free to merge after addressing the migration comment :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t change migrations. Consider them locked the moment they are merged into main.
Instead create a new migrations that alters the table.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is also part of the same release, I avoided adding migrations.

@rathijitpapon rathijitpapon merged commit a3b1aa3 into develop Jun 19, 2024
1 check passed
@rathijitpapon rathijitpapon deleted the eng-204 branch June 19, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants