Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password change, profile update API and Email whitelisting #59

Merged
merged 15 commits into from
Jun 25, 2024

Conversation

saifullah-talukder
Copy link
Contributor

@saifullah-talukder saifullah-talukder commented Jun 14, 2024

  1. Password change api implemented
  2. User profile update api implemented
  3. Checking of whether email is whitelisted before allowing registration is implemented.
  4. User group field added.

Copy link

linear bot commented Jun 14, 2024

ENG-179 User API

Copy link
Member

@rathijitpapon rathijitpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Just a few comments with some small changes.

@rathijitpapon rathijitpapon changed the title Password change, profile update API and Email whitelisting [!WIP] Password change, profile update API and Email whitelisting Jun 14, 2024
Copy link
Contributor

@ivarflakstad ivarflakstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Not much to add at this stage :)

@saifullah-talukder saifullah-talukder changed the title [!WIP] Password change, profile update API and Email whitelisting Password change, profile update API and Email whitelisting Jun 25, 2024
@saifullah-talukder saifullah-talukder marked this pull request as ready for review June 25, 2024 03:26
Copy link
Member

@rathijitpapon rathijitpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merge it.

@saifullah-talukder saifullah-talukder merged commit 339e307 into develop Jun 25, 2024
1 check passed
@saifullah-talukder saifullah-talukder deleted the eng-179 branch June 25, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants